SMS Server Tools 3
This site is hosted by Kekekasvi.com
 Menu
Basic information:
Additional information:
Support:
Get SMS Server Tools 3:
Additional Options

 Sponsored links

 Search
Custom Search

 Visitor locations
 
 SMS Server Tools 3 Community
Welcome, Guest. Please login or register. Sat May 25, 2024 11:07
SMSTools3 Community » Help and support Bottom

[fixed in 3.1.9] Ubuntu 64-bit problem

  This topic is locked

Page:  Previous  1  2

Author Post
Administrator
Registered:
May 2009
Location: Jyväskylä, Finland
Thanks, the log helped, as the problem was not that what I was expecting...

This source package has a small change, perhaps it will make a difference:

h t t p : / / smstools3.kekekasvi.com/test/smstools3-3.1.8-test2.tar.gz


« Last edit by keke on Fri Sep 03, 2010 15:33, 167 months ago. »
Member
Registered:
Jun 2010
Location: Rome, Italy
It worked! :mrgreen:

Here is the log...



I've to perform some functionality tests, but the main problem seems resolved.

Thank you very much!

Member
Registered:
Jun 2010
Location: Rome, Italy
A new problem arised with 3.1.8-test2:

Here is a missed call file:

root@server:/var/spool/sms/incoming# cat GSM1.GG66RV
From: 393283111124
From_TOA: 91 international, ISDN/telephone
Subject: GSM1
Modem: GSM1
IMSI: 222992303587215
Call_type: missed
Received: 10-06-15 16:53:15

CALL MISSED

The From: field is wrong. The correct caller is 393287311124.

Have you changed anything related to this field?

Administrator
Registered:
May 2009
Location: Jyväskylä, Finland
creator wrote
The From: field is wrong. The correct caller is 393287311124.

Have you changed anything related to this field?

No. But this may be related to the same problem.

Here is a new version:

h t t p : / / smstools3.kekekasvi.com/test/smstools3-3.1.8-test3.tar.gz


« Last edit by keke on Fri Sep 03, 2010 15:33, 167 months ago. »
Member
Registered:
Jun 2010
Location: Rome, Italy
3.1.8-test3 worked. CLI is correct now.

I've seen that the patch consists in replacing

strcpy()

with

#define strcpy_overlap(dest,src) memmove(dest, src, strlen(src) +1)

Why? Just for curiosity's sake :)

Administrator
Registered:
May 2009
Location: Jyväskylä, Finland
creator wrote
3.1.8-test3 worked. CLI is correct now.

Thank's for the testing.

However, there are still some places where this problem may occur. I try to publish 3.1.9 tomorrow, after reviewed all of the code couple of times.

creator wrote
I've seen that the patch consists in replacing

strcpy()

with

#define strcpy_overlap(dest,src) memmove(dest, src, strlen(src) +1)

Why? Just for curiosity's sake :)

When manipulating strings, the coding style assumed that strcpy() and some other functions start copying from the begin of a buffer. That's how those have worked for years, but now with the latest 64bit Ubuntu this be behavior has changed, probably when running it with two processors (or with dual core). On AMD64 (single core) everything still works as before.

I used that macro to allow fast search/replace, instead of editing all calls to include third argument.

Anyway, this is a serious bug in smsd, because the manual of those functions says that buffers may not overlap. :oops:

Administrator
Registered:
May 2009
Location: Jyväskylä, Finland
The 3.1.9 is now available.

  This topic is locked

Page:  Previous  1  2

SMSTools3 Community » Help and support Top

 
Time in this board is UTC.  

Privacy Policy   SMS Server Tools 3 Copyright © Keijo Kasvi.