Hello there,

i'd like to introduce myself with a way to send SMS over TCP/IP.

Comments and enhancements welcome!!

Ok, i start with the bash-script:


I think the code is very selfexplaining,
if not, let me know...

here is how i make the script talking over the network:

tcpserver <IP.ADD.DRE.SS> <PORT#> /path/to/script.sh

cheers
Ronny

Thanks.

In what environment you have tested this script?

It did not work under Ubuntu GNU/Linux. Some minor changes were required: variable names are case sensitive (nummer vs. NUMMER), destination number must be in the same line with "To: ", and there must be single empty line between header lines and the message body.

The modified script could be:

#!/bin/bash echo PASSWORD: read PASS PASS=(`echo $PASS | tr -d [:cntrl:]`) if [ "$PASS" = "12345" ]; then echo NUMBER: #add error treatment read NUMMER #add error treatment echo TEXT: read -d^ TEXT #quit on ^ TMPF=(`tempfile`) echo "To: $NUMMER" > $TMPF echo "" >> $TMPF echo $TEXT >> $TMPF mv $TMPF /var/spool/sms/outgoing/ else exit fi

Have you checked the script sendsms, located in the scripts directory of a package? That script can also be used with tcpserver, but it has no password protection by default.

damn...

sorry, i posted a preversion
and didnt doublecheck it

but generally the way should be clear...

the tcpserver testing was done in ubuntu lucid.
i'll try it this week on a debian, which will be the productive system.


be aware, i used the german word for number NUMMER for the ECHO , just if it confused someone...

hm, no i didnt recognize sendsms would work with tcpserver,
but i think any kind of passwordprotection should be used...


i got another script in progress,
which will do:
sms forwarding to (defined) groups via sms
sms forwarding to emailaddresses via shortname-email-matchfile
valid/invalid sender number (black/whitelist)
logging

but... perhaps you will tell me, everything of that is already onboard?
sry, but i'm not yet so deep into sms server tools...

buster wrote

but generally the way should be clear...

the tcpserver testing was done in ubuntu lucid.
i'll try it this week on a debian, which will be the productive system.

Yes, it's clear, and surely tcpserver will run successfully on Debian too.

buster wrote

be aware, i used the german word for number NUMMER for the ECHO , just if it confused someone...

Not confused , but notice that case sensitivity. Shell script does not show any errors when names are typed differently.

buster wrote

hm, no i didnt recognize sendsms would work with tcpserver,
but i think any kind of passwordprotection should be used...

Yes, and protection could be useful for local usage too. Here is a new sendsms script which can use keys, one or more:

#!/bin/sh # This script send a text sms at the command line by creating # a sms file in the outgoing queue. # $1 is the destination phone number. # $2 is the message text. # If you leave $2 or both empty, the script will ask you. # If you give more than 2 arguments, last is taken as a text and # all other are taken as destination numbers. # If a destination is asked, you can type multiple numbers # delimited with spaces. # Keys for example: "password" and "keke": # KEYS="5f4dcc3b5aa765d61d8327deb882cf99 4a5ea11b030ec1cfbc8b9947fdf2c872 " KEYS="" # When creating keys, remember to use -n for echo: # echo -n "key" | md5sum smsd_user="smsd" # Will need echo which accepts -n argument: ECHO=echo case `uname` in SunOS) ECHO=/usr/ucb/echo ;; esac if ! [ -z "$KEYS" ]; then printf "Key: " read KEY if [ -z "$KEY" ]; then echo "Key required, stopping." exit 1 fi KEY=`$ECHO -n "$KEY" | md5sum | awk '{print $1;}'` if ! echo "$KEYS" | grep "$KEY" >/dev/null; then echo "Incorrect key, stopping." exit 1 fi fi DEST=$1 TEXT=$2 if [ -z "$DEST" ]; then printf "Destination(s): " read DEST if [ -z "$DEST" ]; then echo "No destination, stopping." exit 1 fi fi if [ -z "$TEXT" ]; then printf "Text: " read TEXT if [ -z "$TEXT" ]; then echo "No text, stopping." exit 1 fi fi if [ $# -gt 2 ]; then n=$# while [ $n -gt 1 ]; do destinations="$destinations $1" shift n=`expr $n - 1` done TEXT=$1 else destinations=$DEST fi echo "-- " echo "Text: $TEXT" owner="" if [ -f /etc/passwd ]; then if grep $smsd_user: /etc/passwd >/dev/null; then owner=$smsd_user fi fi for destination in $destinations do echo "To: $destination" TMPFILE=`mktemp /tmp/smsd_XXXXXX` $ECHO "To: $destination" >> $TMPFILE $ECHO "" >> $TMPFILE $ECHO -n "$TEXT" >> $TMPFILE if [ "x$owner" != x ]; then chown $owner $TMPFILE fi FILE=`mktemp /var/spool/sms/outgoing/send_XXXXXX` mv $TMPFILE $FILE done

buster wrote

i got another script in progress,
which will do:
sms forwarding to (defined) groups via sms
sms forwarding to emailaddresses via shortname-email-matchfile
valid/invalid sender number (black/whitelist)
logging

but... perhaps you will tell me, everything of that is already onboard?

If you are going to forward incoming messages, this all can be done with an eventhandler script. But as far as I remember here is no complete script published with all of those features.

Outgoing messages can be handled using the checkhandler. For example, some ToGroup: header can be used and the script could check it and write message files with To: <number> header, as many files as necessary.

Feel free to publish you innovations.

here we go...

#!/bin/bash # V0.1 /usr/bin/logger -p local7.notice "SMSGATE START `/bin/date`" ## create neccessary files and folders ## modify syslog (fac7) for smsgate ## sendEmail must be installed ## watch out for typos, there may be some :( ## mail is a matchfile, syntax: shortname email@address.xxx ## groups is a folder, in which reside the groupfiles (admin,info whatever...) with only mobilenumbers in it ## ## hope i didnt forget too much.... ## ## i will have to have a look in the existing scripts for enhancement if i got the time... ## ##VARS ROOTDIR=/var/spool/sms INCOMING=/var/spool/sms/incoming SENT=/var/spool/sms/sent OUTGOING=/var/spool/sms/outgoing CONF=/etc/smsgate GROUPS=/etc/smsgate/groups MAIL=/etc/smsgate/mail for i in `ls /var/spool/sms/incoming/` do ##Nachrichten einlesen#read message FROM=(`grep "From:" $INCOMING/$i | cut -d" " -f2`) ##Erste Zeile einlesen FIRSTLINE=("`grep "Length:" -A2 $INCOMING/$i | tail -n1`") ##Erstes Wort (Keyword) einlesen# read (first) keyword FIRSTWORD=("`grep "Length:" -A2 $INCOMING/$i | tail -n1| cut -d" " -f1`") ##Wenn gültiger Sender#if sender valid if [ "$FROM" == "49171xxxxxxxxx" ]; then case "$FIRSTWORD" in ##BEI BULKSMS#key BULK BULK) ##GRUPPE AUS SMS LESEN#read group GROUP=("`grep "Length:" -A2 $INCOMING/$i | tail -n1| cut -d" " -f2`") ##PRÜFEN OB GRUPPE VORHANDEN IST#check if group is availible if test -f /etc/smsgate/groups/$GROUP; then ##AN JEDES MITGLIED EINE SMS VERSENDEN#send a sms per member for x in `cat /etc/smsgate/groups/$GROUP` do ###SMS VERSENDEN##sendsms-as usual... ### sendsms .....NOCH TESTEN!!!!#to be tested - not yet implemented ;) /usr/bin/logger -p local7.notice "BULKSMS SENT from $FROM to $x" done rm $INCOMING/$i else ##WENN DIE GRUPPE NICHT VORHANDEN IST...#if group is not availible /usr/bin/logger -p local7.error "BULKSMS NOT SENT FROM $FROM to $GROUP - $GROUP not availible - MOVED TO $ROOTDIR/failed/" mv $INCOMING/$i $ROOTDIR/failed/ fi /usr/bin/logger -p local7.error "BULKSMS NOT SENT FROM $FROM to $GROUP - $GROUP not availible - MOVED TO $ROOTDIR/failed/" mv $INCOMING/$i $ROOTDIR/failed/ ;; MAIL) ##EMPFÄNGER AUSLESEN#read recipient RCPT=("`grep "Length:" -A2 $INCOMING/$i | tail -n1| cut -d" " -f2`") ##EMPFÄNGER MAILADRESSE SUCHEN#search mailrecipient in matchfile RCPTADDR=(`grep $RCPT $MAIL | sed 's/^.*\ //'`) if [ "$?" = "0" ]; then ##WENN EMAIL VORHANDEN, SMS ALS MAIL ZUSTELLEN if [ "$RCPTADDR" = '' ]; then mv $INCOMING/$i $ROOTDIR/failed/ continue fi SUBJECT="SMS2MAIL" MESSAGE=("`cat $INCOMING/$i`") ###SMS TEXT NOCH RICHTIG AUSLESEN!!!!##remove headers from received sms - todo: make nicer... its pretty ugly.... cat "$INCOMING/$i" | grep -v "^From_TOA:" | grep -v "^FROM_SMSC:" | grep -v "^Subject:" | grep -v "^Modem:" | grep -v "^IMSI:" | grep -v "^Report:" | grep -v "^Alphabet:" | grep -v "^Length:" | /usr/bin/sendEmail -f sms@sms.motiondrive.ag -u "$SUBJECT" -t "$RCPTADDR" -m /usr/bin/logger -p local7.notice "MAIL SENT FROM $FROM TO $RCPT alias $RCPTADDR" rm $INCOMING/$i else ##EMAIL NICHT VORHANDEN...##rcpt not in matchfile mv $INCOMING/$i $ROOTDIR/failed/ /usr/bin/logger -p local7.error NO MAILADDRESS IN FILE - MOVED TO $ROOTDIR/failed/$i fi ;; *) mv $INCOMING/$i $ROOTDIR/failed/ /usr/bin/logger -p local7.error ERROR IN FILE - MOVED TO $ROOTDIR/failed/$i ;; esac ##Wenn ungültiger Sender#invalid sendernumber else mv $INCOMING/$i $ROOTDIR/failed/ /usr/bin/logger -p local7.error NO VALID SENDER NUMBER FOR FILE - MOVED TO $ROOTDIR/failed/$i continue fi done /usr/bin/logger -p local7.notice "SMSGATE FINISH `/bin/date`"

Comments still welcome?

Anyway...

You are running this script by a cron (or manually). Have you thought that this functionality could be done in the eventhandler script, which means that as soon as the SMS is received, forwarding is done?

When handling incoming files outside of the smsd, it is possible that the file is not yet complete when the script reads it. This is rare, but should still be considered. For example, when the smsd is reading outgoing files, it will check the size, and if it is not changed after one second, the file is handled as a complete file.

I recommend to change the handling of headers and message body of the message file. You are reading a header "Length" as a last header, but it's not always the last, for example when store_incoming_pdu setting is used. In the future versions there can also be another headers. As the format of SMS file is "e-mail format", the command formail could be used for handling of headers. This command is available in the procmail package. Here are three functions which I use for handling with the bash shell:

#!/bin/bash #-------------------------------------------------------------------------- get_header() { # $1 = filename # $2 = header local tmp=`formail -zx "$2" < "$1"` echo "$tmp" } #-------------------------------------------------------------------------- set_header() { # $1 = filename # $2 = header local tmp=`mktemp /tmp/smsd_XXXXXX` cp "$1" $tmp formail -f -I "$2" < $tmp > "$1" unlink $tmp } #-------------------------------------------------------------------------- remove_header() { # $1 = filename # $2 = header local tmp=`formail -zx "$2" < "$1"` if [ "x$tmp" != "x" ]; then tmp=`mktemp /tmp/smsd_XXXXXX` cp "$1" $tmp formail -I $2 < $tmp > "$1" unlink $tmp fi } #--------------------------------------------------------------------------

The message body of a file can also be extracted using the formail, but it will contain extra linefeed in the begin of a text. It can be removed with MESSAGEBODY=`formail -I "" < $FILENAME | sed -e"1d"`, but this command also works (without formail): MESSAGEBODY=`sed -e '1,/^$/ d' < $FILENAME`.

Instead of removing old headers, you can just write new headers, single empty line and $MESSAGEBODY to the new file, or if sending as an e-mail, just echo -n $MESSAGEBODY | ....

Generally taken your script may work, I have not tested it, but I think that it will fail if a SMS message is "Report: OK, Houston, we've had a problem here.".

Quote

Comments still welcome?

yes, still welcome

indeed in the moment its running by cronjob,
but as soon as i read more about eventhandles i wanted to change that...

thanks for all the hints so far,
i will try to get it into the script as good as i can

Quote

but I think that it will fail if a SMS message is "Report: OK, Houston, we've had a problem here.".

hm... why do you think so?

buster wrote

but as soon as i read more about eventhandles i wanted to change that...

Ok. This forum contains lot of samples, try this search.

buster wrote

Quote

but I think that it will fail if a SMS message is "Report: OK, Houston, we've had a problem here.".

hm... why do you think so?

Because you are grepping whole file, not just a header part. If some line in the message body starts with "Report:" (or with any defined header word), the whole line is dropped...

first of all:
thanks to keke for the hints!!

now with ~60 lines less

#!/bin/sh if [ "$1" = "RECEIVED" ]; then TEXT=`formail -I "" <$2` #make uppercase TEXT=`echo $TEXT | tr "a-z" "A-Z" ` FILE=`mktemp /tmp/send_XXXXXX` KEYWORD=`echo $TEXT | cut -d" " -f1` case $KEYWORD in ADMIN) for x in `cat /etc/smsgate/groups/admin` do FORWARD_TO=$x TEXT=`echo $TEXT | sed 's/^ADMIN //'` echo "To: $FORWARD_TO" >> $FILE echo "" >> $FILE echo "$TEXT" >> $FILE FILE2=`mktemp /var/spool/sms/outgoing/send_XXXXXX` mv $FILE $FILE2 done ;; MAIL:*) RCPT=`$KEYWORD | cut -d: -f2` MAILADDR=`grep $RCPT: /etc/smsgate/mail | cut -d: -f2` TEXT=`echo $TEXT | sed 's/^.* //'` /usr/bin/sendEmail -f sms@domain.com -u SMS2MAIL -t "$MAILADDR" -m $TEXT rm $2 ;; esac fi

this line

TEXT=`echo $TEXT | sed 's/ADMIN //'

should be

TEXT=`echo $TEXT | sed 's/^ADMIN //'

(isnt there a edit button?)

buster wrote

(isnt there a edit button?)

For members there is a time window (5 minutes) for editing after posting...


You have not told what OS you are using and what is the version of smsd. In the help/support forum the posting will ask those details, but here in samples those details were not asked.

Your script is using the sh shell. In many cases that is a link to the bash shell, but not always and not on every platforms. I have not checked the syntax of your script, but in many samples the syntax of bash shell is used because it's much more powerful. If you copy some features from the sample scripts, you should use the bash.

i'm using debian lenny for that,
and smsd 3.1.6.
usually i had bash instead of sh there
nevertheless, it works...